Re: [PATCH 05/25] soc: rockchip: io-domain: Remove incorrect and incomplete comment header
From: Lee Jones
Date: Thu Nov 12 2020 - 08:48:05 EST
On Thu, 12 Nov 2020, Heiko Stübner wrote:
> Am Donnerstag, 12. November 2020, 14:28:28 CET schrieb Lee Jones:
> > On Thu, 12 Nov 2020, Heiko Stübner wrote:
> >
> > > Am Donnerstag, 12. November 2020, 14:22:24 CET schrieb Lee Jones:
> > > > On Thu, 12 Nov 2020, Heiko Stübner wrote:
> > > >
> > > > > Am Donnerstag, 12. November 2020, 11:33:44 CET schrieb Lee Jones:
> > > > > > On Tue, 03 Nov 2020, Lee Jones wrote:
> > > > > >
> > > > > > > Fixes the following W=1 kernel build warning(s):
> > > > > > >
> > > > > > > drivers/soc/rockchip/io-domain.c:57: warning: Cannot understand * @supplies: voltage settings matching the register bits.
> > > > > > >
> > > > > > > Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> > > > > > > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> > > > > > > Cc: Mark Brown <broonie@xxxxxxxxxx>
> > > > > > > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> > > > > > > Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
> > > > > > > Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> > > > > > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > > > > > ---
> > > > > > > drivers/soc/rockchip/io-domain.c | 3 ---
> > > > > > > 1 file changed, 3 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/soc/rockchip/io-domain.c b/drivers/soc/rockchip/io-domain.c
> > > > > > > index eece97f97ef8f..d13d2d497720b 100644
> > > > > > > --- a/drivers/soc/rockchip/io-domain.c
> > > > > > > +++ b/drivers/soc/rockchip/io-domain.c
> > > > > > > @@ -53,9 +53,6 @@
> > > > > > >
> > > > > > > struct rockchip_iodomain;
> > > > > > >
> > > > > > > -/**
> > > > > > > - * @supplies: voltage settings matching the register bits.
> > > > > > > - */
> > > > > > > struct rockchip_iodomain_soc_data {
> > > > > > > int grf_offset;
> > > > > > > const char *supply_names[MAX_SUPPLIES];
> > > > > >
> > > > > > Any idea who will pick this up?
> > > > >
> > > > > me :-)
> > > >
> > > > Well, that's certainly a start. :)
> > > >
> > > > What are your plans?
> > >
> > > the usual, my rockchip-tree -> armsoc driver branch -> torvalds -> 5.11 ;-)
> >
> > Sorry, the ambiguity was my fault.
> >
> > When do you plan on hoovering it up?
>
> sorry should've written that directly ... I already did this "morning":
>
> http://lore.kernel.org/r/160517975455.81506.16289432612279089945.b4-ty@xxxxxxxxx
Ah, perfect. Thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog