Re: [PATCH 0/3] Add gpio support for TI's J7200 platform

[Nishanth Menon]

On 00:41-20201103, Faiz Abbas wrote:
> The following patches add gpio support for TI's J7200 platform.
> 
> These patches were posted as a part of an older series but have now
> been split into three parts. The 3 parts add configs, gpios and MMC/SD
> related dts patches respectively.
> 
> Older series is here:
> https://lore.kernel.org/linux-arm-kernel/20201001190541.6364-1-faiz_abbas@xxxxxx/
> 
> Series adding configs to arm64 defconfig is here:
> https://lore.kernel.org/linux-arm-kernel/20201102183005.14174-1-faiz_abbas@xxxxxx/
> 
> Faiz Abbas (3):
>   arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
>   arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain

I am not sure why we are splitting patches per domain here. We
should just have a single patch that introduces the nodes, I dont see a
specific benefit. In addition, series also introduces additional
 Missing #address-cells in interrupt provider

Which we need a conclusion for and the comments already provided.


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D