Re: [PATCH] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

[Gene Chen]

Dear Reviewers,

   Please let me know if there is anything need to be revised.

Gene Chen <gene.chen.richtek@xxxxxxxxx> 於 2020年8月20日 週四 下午4:36寫道：
>
> From: Gene Chen <gene_chen@xxxxxxxxxxx>
>
> Add bindings for MT6360 PMIC
>
> Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/mt6360.yaml | 142 ++++++++++++++++++++++
>  1 file changed, 142 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> new file mode 100644
> index 0000000..5ad1afd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> @@ -0,0 +1,142 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6360 PMIC from MediaTek Integrated
> +
> +maintainers:
> +  - Gene Chen <gene_chen@xxxxxxxxxxx>
> +
> +description: |
> +  MT6360 is a PMIC device with the following sub modules.
> +  It is interfaced to host controller using I2C interface.
> +
> +  This document describes the binding for PMIC device and its sub module.
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt6360
> +
> +  reg:
> +    description:
> +      I2C device address.
> +    maxItems: 1
> +
> +  wakeup-source: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +      enum:
> +        - IRQB
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 1
> +    description:
> +      The first cell is the IRQ number.
> +
> +  regulator:
> +    $ref: ../regulator/mt6360-regulator.yaml
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-controller
> +  - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mt6360@34 {
> +            compatible = "mediatek,mt6360";
> +            reg = <0x34>;
> +            wakeup-source;
> +            interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-names = "IRQB";
> +            interrupt-controller;
> +            #interrupt-cells = <1>;
> +            regulator {
> +                compatible = "mediatek,mt6360-regulator";
> +                LDO_VIN3-supply = <&BUCK2>;
> +                buck1 {
> +                    regulator-compatible = "BUCK1";
> +                    regulator-name = "mt6360,buck1";
> +                    regulator-min-microvolt = <300000>;
> +                    regulator-max-microvolt = <1300000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP
> +                                               MT6360_OPMODE_ULP>;
> +                };
> +                BUCK2: buck2 {
> +                regulator-compatible = "BUCK2";
> +                    regulator-name = "mt6360,buck2";
> +                    regulator-min-microvolt = <300000>;
> +                    regulator-max-microvolt = <1300000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP
> +                                               MT6360_OPMODE_ULP>;
> +                };
> +                ldo6 {
> +                    regulator-compatible = "LDO6";
> +                    regulator-name = "mt6360,ldo6";
> +                    regulator-min-microvolt = <500000>;
> +                    regulator-max-microvolt = <2100000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +                ldo7 {
> +                    regulator-compatible = "LDO7";
> +                    regulator-name = "mt6360,ldo7";
> +                    regulator-min-microvolt = <500000>;
> +                    regulator-max-microvolt = <2100000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +                ldo1 {
> +                    regulator-compatible = "LDO1";
> +                    regulator-name = "mt6360,ldo1";
> +                    regulator-min-microvolt = <1200000>;
> +                    regulator-max-microvolt = <3600000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +                ldo2 {
> +                    regulator-compatible = "LDO2";
> +                    regulator-name = "mt6360,ldo2";
> +                    regulator-min-microvolt = <1200000>;
> +                    regulator-max-microvolt = <3600000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +                ldo3 {
> +                    regulator-compatible = "LDO3";
> +                    regulator-name = "mt6360,ldo3";
> +                    regulator-min-microvolt = <1200000>;
> +                    regulator-max-microvolt = <3600000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +                ldo5 {
> +                    regulator-compatible = "LDO5";
> +                    regulator-name = "mt6360,ldo5";
> +                    regulator-min-microvolt = <2700000>;
> +                    regulator-max-microvolt = <3600000>;
> +                    regulator-allowed-modes = <MT6360_OPMODE_NORMAL
> +                                               MT6360_OPMODE_LP>;
> +                };
> +            };
> +        };
> +    };
> --
> 2.7.4
>