Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'

[Lee Jones]

On Thu, 12 Nov 2020, Leo Li wrote:

> 
> 
> > -----Original Message-----
> > From: Lee Jones <lee.jones@xxxxxxxxxx>
> > Sent: Thursday, November 12, 2020 4:33 AM
> > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > Qiang Zhao <qiang.zhao@xxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Scott
> > Wood <scottwood@xxxxxxxxxxxxx>; act <dmalek@xxxxxxx>; Dan Malek
> > <dan@xxxxxxxxxxxxxxxxx>; Software, Inc <source@xxxxxxxxxx>; Vitaly
> > Bordug <vbordug@xxxxxxxxxxxxx>; linuxppc-dev@xxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function
> > attribute 'addr'
> > 
> > On Tue, 03 Nov 2020, Lee Jones wrote:
> > 
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > >  drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or
> > member 'addr' not described in 'cpm_muram_dma'
> > >  drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
> > 'offset' description in 'cpm_muram_dma'
> > >
> > > Cc: Qiang Zhao <qiang.zhao@xxxxxxx>
> > > Cc: Li Yang <leoyang.li@xxxxxxx>
> > > Cc: Scott Wood <scottwood@xxxxxxxxxxxxx>
> > > Cc: act <dmalek@xxxxxxx>
> > > Cc: Dan Malek <dan@xxxxxxxxxxxxxxxxx>
> > > Cc: "Software, Inc" <source@xxxxxxxxxx>
> > > Cc: Vitaly Bordug <vbordug@xxxxxxxxxxxxx>
> > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > ---
> > >  drivers/soc/fsl/qe/qe_common.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/soc/fsl/qe/qe_common.c
> > > b/drivers/soc/fsl/qe/qe_common.c index 75075591f6308..497a7e0fd0272
> > > 100644
> > > --- a/drivers/soc/fsl/qe/qe_common.c
> > > +++ b/drivers/soc/fsl/qe/qe_common.c
> > > @@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
> > >
> > >  /**
> > >   * cpm_muram_dma - turn a muram virtual address into a DMA address
> > > - * @offset: virtual address from cpm_muram_addr() to convert
> > > + * @addr: virtual address from cpm_muram_addr() to convert
> > >   */
> > >  dma_addr_t cpm_muram_dma(void __iomem *addr)  {
> > 
> > Any idea who will pick this up?
> 
> I can pick them up through my tree, but I haven't created the
> for-next branch for the next kernel yet.  Will look through this
> series soon.  Thanks.

Thank you Leo.

There's not rush.  Just trying to ensure they don't get forgotten.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog