Re: [PATCH RFC v5 01/13] perf jevents: Add support for an extra directory level

From: John Garry
Date: Fri Nov 13 2020 - 04:24:55 EST


On 13/11/2020 08:48, kajoljain wrote:

On 11/6/20 6:05 PM, John Garry wrote:
Currently only upto a level 2 directory is supported, in form
vendor/platform.
Hi John,
Just want to check in case of sub directories,
Will it be good add on/feasible to be able to include events of particular sub-directory for a
platform? Otherwise with this patch in the end all event will be part of
same pmu_event structure. So what is the purpose of sub directories? Let me know if I am missing something.

Hi Kajol Jain,

So currently we support both of the following structure:
arch/platform
arch/vendor/platform/

arch/vendor/platform/ is for an arch like arm, where the arch provider may not be the vendor.

I want to go one step further, to support also:
arch/vendor/platform/cpu
arch/vendor/platform/sys

Here we have separate folders for cpu and sys events. CPU events in "cpu" folder are added to pmu_events_map[], as before. And events in "sys" folder are added from patch 2/13 to new table pmu_sys_events_table[].

I hope it's clearer now.

Thanks,
John


Thanks,
Kajol Jain
Add support for a further level, to support vendor/platform
sub-directories in future.