Re: [PATCH 32/40] drm/msm/disp/mdp5/mdp5_crtc: Make local function 'mdp5_crtc_setup_pipeline()' static

[abhinavk]

On 2020-11-13 05:49, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:581:5: warning: no previous
> prototype for ‘mdp5_crtc_setup_pipeline’ [-Wmissing-prototypes]
>
> Cc: Rob Clark <robdclark@xxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Reviewed-by: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> index 79dd56faf3de0..0c8f9f88301fa 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> @@ -578,9 +578,9 @@ static void mdp5_crtc_atomic_enable(struct drm_crtc 
> *crtc,
>  	mdp5_crtc->enabled = true;
>  }
>
> -int mdp5_crtc_setup_pipeline(struct drm_crtc *crtc,
> -			     struct drm_crtc_state *new_crtc_state,
> -			     bool need_right_mixer)
> +static int mdp5_crtc_setup_pipeline(struct drm_crtc *crtc,
> +				    struct drm_crtc_state *new_crtc_state,
> +				    bool need_right_mixer)
>  {
>  	struct mdp5_crtc_state *mdp5_cstate =
>  			to_mdp5_crtc_state(new_crtc_state);