Re: [PATCH kernel v3] genirq/irqdomain: Add reference counting to IRQs

From: Frederic Barrat
Date: Sat Nov 14 2020 - 04:49:36 EST


On 14/11/2020 04:37, Alexey Kardashevskiy wrote:

I'll try to go through this patch over the week-end (or more probably
early next week), and try to understand where our understandings
differ.

Great, thanks! Fred spotted a problem with irq_free_descs() not doing kobject_put() anymore and this is a problem for sa1111.c and the likes and I will go though these places anyway.

So there are callers out there which don't care about mapping the interrupt. Wouldn't it be easier to leave alone the kobject from the irq descriptor (my understanding is that it's there to handle the sysfs representation) and add a simple kref counter, just to handle the mapping part?

Fred