Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
From: Greg KH
Date: Sat Nov 14 2020 - 05:23:37 EST
On Sat, Nov 14, 2020 at 05:47:47PM +0800, Jiaxun Yang wrote:
>
>
> 在 2020/11/14 下午4:15, Greg KH 写道:
>
> + qemu-riscv list and QEMU device maintainers of goldfish_rtc
>
> > On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> > > Hi, All,
> > >
> > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> > > as well, so I think we should keep it in kernel.
> > But does anyone actually use it for anything? Having something in qemu
> > is nice, but not required if it doesn't provide something that is
> > already there for other virtual devices, right?
>
> Hi all,
>
> Both QEMU MIPS loongson3-virt and riscv virt machine are using goldfish_rtc
> as sole RTC
> device, it have been hardcoded in QEMU for a long while and sudden drop in
> kernel would
> break these machines.
> RTC is essential for virt machines to keep time synchronized with host.
>
> Given that it is the simplest RTC implementation for now, it won't give us
> much maintenance
> overhead.
>
> Thus I do think it shouldn't be retired as for now. If nobody comes in I'd
> also willing to maintain
> it.
Ok, can someone submit a patch to update the MAINTAINERS file for this
so we know who to route issues to over time?
thanks,
greg k-h