RE: [EXT] Re: [PATCH v3 net-next 00/13] Add ethtool ntuple filters support

[Naveen Mamindlapalli]

Hi Saeed,
Thanks for the review.

> -----Original Message-----
> From: Saeed Mahameed <saeed@xxxxxxxxxx>
> Sent: Friday, November 13, 2020 1:47 AM
> To: Naveen Mamindlapalli <naveenm@xxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Cc: kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx; Sunil Kovvuri Goutham
> <sgoutham@xxxxxxxxxxx>; Linu Cherian <lcherian@xxxxxxxxxxx>;
> Geethasowjanya Akula <gakula@xxxxxxxxxxx>; Jerin Jacob Kollanukkaran
> <jerinj@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>;
> Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH v3 net-next 00/13] Add ethtool ntuple filters support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, 2020-11-11 at 12:43 +0530, Naveen Mamindlapalli wrote:
> > This patch series adds support for ethtool ntuple filters, unicast
> > address filtering, VLAN offload and SR-IOV ndo handlers. All of the
> > above features are based on the Admin Function(AF) driver support to
> > install and delete the low level MCAM entries. Each MCAM entry is
> > programmed with the packet fields to match and what actions to take if
> > the match succeeds. The PF driver requests AF driver to allocate set
> > of MCAM entries to be used to install the flows by that PF. The
> > entries will be freed when the PF driver is unloaded.
> >
> > * The patches 1 to 4 adds AF driver infrastructure to install and
> >   delete the low level MCAM flow entries.
> > * Patch 5 adds ethtool ntuple filter support.
> > * Patch 6 adds unicast MAC address filtering.
> > * Patch 7 adds support for dumping the MCAM entries via debugfs.
> > * Patches 8 to 10 adds support for VLAN offload.
> > * Patch 10 to 11 adds support for SR-IOV ndo handlers.
> > * Patch 12 adds support to read the MCAM entries.
> >
> > Misc:
> > * Removed redundant mailbox NIX_RXVLAN_ALLOC.
> >
> > Change-log:
> > v3:
> > - Fixed Saeed's review comments on v2.
> > 	- Fixed modifying the netdev->flags from driver.
> > 	- Fixed modifying the netdev features and hw_features after
> > register_netdev.
> > 	- Removed unwanted ndo_features_check callback.
> > v2:
> > - Fixed the sparse issues reported by Jakub.
> >
> 
> Reviewed-by: Saeed Mahameed <saeedm@xxxxxxxxxx>