Re: [PATCH net] net: x25: Correct locking for x25_kill_by_device and x25_kill_by_neigh

[Xie He]

On Sat, Nov 14, 2020 at 2:36 AM Xie He <xie.he.0141@xxxxxxxxx> wrote:
>
> This patch adds correct locking for x25_kill_by_device and
> x25_kill_by_neigh, and removes the incorrect locking in x25_connect and
> x25_disconnect.

I see if I do this change, I need to make sure the sock lock is not
held when calling x25_remove_socket, to prevent deadlock.

Sorry. I'll deal with this issue and resubmit.

I also see that in x25_find_listener and __x25_find_socket, when we
traverse x25_list, we should probably also hold the sock lock when we
read the element of the list, and continue to hold the lock when we
find the sock we want.