Re: [PATCH RESEND net-next 06/18] net: phy: marvell: remove the use of .ack_interrupt()
From: Andrew Lunn
Date: Sun Nov 15 2020 - 16:00:45 EST
On Fri, Nov 13, 2020 at 06:52:14PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@xxxxxxx>
>
> In preparation of removing the .ack_interrupt() callback, we must replace
> its occurrences (aka phy_clear_interrupt), from the 2 places where it is
> called from (phy_enable_interrupts and phy_disable_interrupts), with
> equivalent functionality.
>
> This means that clearing interrupts now becomes something that the PHY
> driver is responsible of doing, before enabling interrupts and after
> clearing them. Make this driver follow the new contract.
>
> Cc: Maxim Kochetkov <fido_max@xxxxxxxx>
> Cc: Baruch Siach <baruch@xxxxxxxxxx>
> Cc: Robert Hancock <robert.hancock@xxxxxxxxxx>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
Hi Ioana
I tested this series on a couple of Marvell Ethernet switches with
integrated PHYs using interrupts. Please feel free to add
Tested-by: Andrew Lunn <andrew@xxxxxxx>
to this and the previous patch.
Andrew