Re: [PATCH RFC 02/12] vdpa: split vdpasim to core and net modules

[Stefano Garzarella]

On Mon, Nov 16, 2020 at 12:00:11PM +0800, Jason Wang wrote:
> On 2020/11/13 下午9:47, Stefano Garzarella wrote:
> > From: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
> >
> > Introduce new vdpa_sim_net and vdpa_sim (core) drivers. This is a
> > preparation for adding a vdpa simulator module for block devices.
> >
> > Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
> > [sgarzare: various cleanups/fixes]
> > Signed-off-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
> > ---
> > v1:
> > - Removed unused headers
> > - Removed empty module_init() module_exit()
> > - Moved vdpasim_is_little_endian() in vdpa_sim.h
> > - Moved vdpasim16_to_cpu/cpu_to_vdpasim16() in vdpa_sim.h
> > - Added vdpasim*_to_cpu/cpu_to_vdpasim*() also for 32 and 64
> > - Replaced 'select VDPA_SIM' with 'depends on VDPA_SIM' since selected
> >   option can not depend on other [Jason]
>
>
> If possible, I would suggest to split this patch further:
>
> 1) convert to use void *config, and an attribute for setting config 
> size during allocation
> 2) introduce supported_features
> 3) other attributes (#vqs)
> 4) rename config ops (more generic one)
> 5) introduce ops for set|get_config, set_get_features
> 6) real split

Okay, I'll try to split Max's patch following your suggestion.
It should be cleaner.

Thanks,
Stefano