Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

From: Lee Jones
Date: Mon Nov 16 2020 - 05:25:56 EST


On Mon, 16 Nov 2020, Sam Ravnborg wrote:

> Hi Lee,
> On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote:
> > On Sat, 14 Nov 2020, Sam Ravnborg wrote:
> >
> > > Hi Lee,
> > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > > > Fixes the following W=1 kernel build warning(s):
> > > >
> > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > > >
> > > > Cc: Eric Anholt <eric@xxxxxxxxxx>
> > > > Cc: David Airlie <airlied@xxxxxxxx>
> > > > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > >
> > > Eric's was not copied on this or the other pl111 patch.
> > > Added Eric so he can be aware of this fix.
> >
> > Eric Anholt?
> >
> > He's on Cc?
> Not on the original mail I received.

Looks fine to me:

Date: Fri, 13 Nov 2020 13:49:10 +0000
From: Lee Jones <lee.jones@xxxxxxxxxx>
To: lee.jones@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx, Eric Anholt <eric@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

Also reflected in Gmail:

https://i.imgur.com/d69YTzz.png

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog