Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough

From: Miguel Ojeda
Date: Mon Nov 16 2020 - 06:33:14 EST


On Mon, Nov 16, 2020 at 5:35 AM Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
>
> The "fallthrough" pseudo-keyword was added as a portable way to denote
> intentional fallthrough. Clang will still warn on cases where there is a
> fallthrough to an immediate break. Add explicit breaks for those cases.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/236
> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

It makes things clearer having a `break` added, so I like that warning.

Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Cheers,
Miguel