Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC

From: Ulf Hansson
Date: Mon Nov 16 2020 - 06:41:48 EST


On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@xxxxxxxxx> wrote:
>
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx>
>
> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling")
> introduces platform specific SDHCI clock operation.
>
> This patch declares the clock operation for Keem Bay.
> Add clk_ops for SD, EMMC and SDIO operations.

The above commit message doesn't really tell why or what goes on here.
Can please try to clarify that.

>
> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay")

Is $subject patch fixing a bug/regression?

Kind regards
Uffe

>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx>
> Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 829ccef87426..012d52e1abee 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data sdhci_arasan_versal_data = {
> static struct sdhci_arasan_of_data intel_keembay_emmc_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_emmc_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static struct sdhci_arasan_of_data intel_keembay_sd_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_sd_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
> .soc_ctl_map = &intel_keembay_soc_ctl_map,
> .pdata = &sdhci_keembay_sdio_pdata,
> + .clk_ops = &arasan_clk_ops,
> };
>
> static const struct of_device_id sdhci_arasan_of_match[] = {
> --
> 2.17.1
>