Re: [PATCH] perf vendor events: Update Skylake client events to v50

From: Andi Kleen
Date: Mon Nov 16 2020 - 09:54:08 EST


> I'd prefer if we could make a copy of these scripts into the kernel tree
> along with the data files from:
> https://download.01.org/perfmon/

FWIW I originally tried this to include the raw JSON files, but Ingo objected
and wanted the files to be split up[1] and avoiding redundant headers.
That's why we ended up with the "compiled" format.

[1] https://lkml.org/lkml/2015/5/28/336

> Having a generated file that can't be edited, reviewed, .. I also worry
> that if/when we change the json format then event-converter-for-linux-perf
> will need to support a multitude of perf versions.

You mean for backports? The assumption was that perf backports would backport
any perf changes for new formats too.

In general I generally discourage any perf tools backport, people should just use
a new version of the perf tool on old kernels.

In principle the scripts could be included, but without the raw files it would
be somewhat pointless.

-andi