Re: [PATCH] samples/ftrace: mark my_tramp[12]? global

[Sami Tolvanen]

On Mon, Nov 16, 2020 at 8:39 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Fri, 13 Nov 2020 10:34:14 -0800
> Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> > my_tramp[12]? are declared as global functions in C, but they are not
> > marked global in the inline assembly definition. This mismatch confuses
> > Clang's Control-Flow Integrity checking. Fix the definitions by adding
> > .globl.
> >
>
> Actually, since that function is not really global, would it work if you
> removed the "extern" from the my_tramp declaration?

Unfortunately not, removing the "extern" doesn't seem to change anything.

> In other words, is there a way to tell C that a function is declared in an
> inline assembly block?

I'm not sure if there's a way to tell C that a static function is
declared in inline assembly. At least I couldn't find a way that would
make the compiler happy.

Sami