Re: drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used

[Ben Hutchings]

On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote:
> Hello Ben,
> 
> A long time ago you added a dependency for speakup drivers on
> CONFIG_ISA, and you also added || COMPILE_TEST as an alternative.
> 
> It seems that some platform portability tests then think they should
> be able to build it, even if they don't enable ISA, but then we are
> getting warnings, or even errors, depending on the compatibility macros
> in <asm/io.h> in the !ISA case (here, the parisc compatibility macros do
> not consume their parameter).
> 
> Perhaps we should rather use
> 
> depends on ISA || (X86 && COMPILE_TEST)
> 
> ?
> so that we have compile testing on x86 only (where the inb/outb macros
> always behave fine) to avoid such issues on other archs?

That seems reasonable though unusual.

> Or we tell the architecture maintainers to fix their out macros into
> consuming their parameters?
[...]

It does seem odd for parisc to define the I/O functions this way.  I
don't know if it's really a bug.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                      - Albert Einstein

Attachment: signature.asc
Description: This is a digitally signed message part