Re: linux-next: build failure after merge of the mhi tree

From: Kalle Valo
Date: Tue Nov 17 2020 - 04:16:10 EST


Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> writes:

> On Tue, Nov 17, 2020 at 09:53:59AM +0530, Manivannan Sadhasivam wrote:
>> +ath11k list, kalle
>>
>
> Oops... adding now
>
>> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> > failed like this:
>> >
>> > drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 27 | .auto_start = false,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 42 | .auto_start = false,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 57 | .auto_start = true,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 72 | .auto_start = true,
>> > | ^~~~~~~~~~
>> >
>> > Caused by commit
>> >
>> > 0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
>> >
>>
>> The fixing patch [1] should've landed in ath-next. Kalle can you please
>> apply the patch on top of immutable branch?
>>
>> Stephen, feel free to pick it up in the meantime.

I think this fix should be included in commit 0cc1f3a385b2 ("bus: mhi:
Remove auto-start option"), otherwise the build will always fail. I can
then pull this commmit from the MHI immutable branch to my ath.git tree
and from there it will go to wireless-drivers-next.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches