Re: [PATCH v3 3/3] ARM: dts: add Protonic WD3 board

[Marc Kleine-Budde]

On 11/17/20 11:38 AM, Oleksij Rempel wrote:
> Protonic WD3 is a proof of concept platform for tractor e-cockpit applications
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/Makefile          |   1 +
>  arch/arm/boot/dts/imx6qp-prtwd3.dts | 552 ++++++++++++++++++++++++++++
>  2 files changed, 553 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6qp-prtwd3.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 3c17387752c0..a2197907bc4f 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -587,6 +587,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>  	imx6qp-nitrogen6_max.dtb \
>  	imx6qp-nitrogen6_som2.dtb \
>  	imx6qp-phytec-mira-rdk-nand.dtb \
> +	imx6qp-prtwd3.dtb \
>  	imx6qp-sabreauto.dtb \
>  	imx6qp-sabresd.dtb \
>  	imx6qp-tx6qp-8037.dtb \
> diff --git a/arch/arm/boot/dts/imx6qp-prtwd3.dts b/arch/arm/boot/dts/imx6qp-prtwd3.dts
> new file mode 100644
> index 000000000000..a93aa3776db6
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6qp-prtwd3.dts
> @@ -0,0 +1,552 @@
[...]

> +	clock_mcp251xfd: clock-mcp251x {
                         clock-mcp251xfd

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <20000000>;
> +	};

[...]

> +&ecspi3 {
> +	cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi3>;
> +	status = "okay";
> +
> +	can@0 {
> +		compatible = "microchip,mcp251xfd";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_can2>;
> +		reg = <0>;
> +		clocks = <&clock_mcp251xfd>;
> +		spi-max-frequency = <5000000>;

Usually make spi-max-frequency clock/2, so 10MHz.

> +		interrupts-extended = <&gpio4 25 IRQ_TYPE_EDGE_FALLING>;

Please make it IRQ_TYPE_LEVEL_LOW.

> +	};
> +};

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature