Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

[Krzysztof Kozlowski]

On Tue, 17 Nov 2020 at 11:56, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>
> On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote:
> > The iMX DRM drivers use Common Clock Framework thus they cannot be built
> > on platforms without it (e.g. compile test on MIPS with RALINK and
> > SOC_RT305X):
> >
> >     /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
> >     imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Thank you, but could this be added to
>
> config DRM_IMX_LDB
>
> instead?
>
> The core DRM_IMX code does not use the Common Clock Framework directly.
> DRM_IMX_TVE already depends on COMMON_CLK because it implements a clock.

You're right, I even wanted to add it there but somehow it landed in
the main entry... Thanks, I'll send a v2.

Best regards,
Krzysztof