Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

From: Matthias Brugger
Date: Tue Nov 17 2020 - 07:05:06 EST


Hi Lee,

On 13/11/2020 11:19, Lee Jones wrote:
On Tue, 10 Nov 2020, Enric Balletbo i Serra wrote:

This adds syscon_regmap_lookup_by_phandle_optional() function to get an
optional regmap.

It behaves the same as syscon_regmap_lookup_by_phandle() except where
there is no regmap phandle. In this case, instead of returning -ENODEV,
the function returns NULL. This makes error checking simpler when the
regmap phandle is optional.

Suggested-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
---

Changes in v2:
- Add Matthias r-b tag.
- Add the explanation from the patch description to the code.
- Return NULL instead of -ENOTSUPP when regmap helpers are not enabled.

drivers/mfd/syscon.c | 18 ++++++++++++++++++
include/linux/mfd/syscon.h | 11 +++++++++++
2 files changed, 29 insertions(+)

Applied, thanks.


I've a series [1] that's based on this patch, could you provide a stable branch for it, so that I can take the series.

Thanks,
Matthias

[1] https://lore.kernel.org/linux-mediatek/20201030113622.201188-1-enric.balletbo@xxxxxxxxxxxxx/