Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

From: Florian Fainelli
Date: Tue Nov 17 2020 - 10:08:44 EST




On 11/17/2020 5:45 AM, Andrew Lunn wrote:
>>> Do you have the Marvell PHY driver either built-in or available as a
>>> module? I suspect the problem is you don't. You will need the Marvell
>>> PHY driver to correctly drive the PHY, you can't rely on the fallback
>>> driver for SFPs.
>> Correct. I was using the generic driver and that does clearly not
>> work. After including the Marvell driver the callback to the validate
>> function happens as expected. Thanks for the support.
>
> Hi Russell
>
> Maybe we should have MDIO_I2C driver select the Marvell PHY driver?

It was suggested a while ago that MARVELL_PHY follow the SFP
configuration symbol and that we would warn when a CuSFP module was used
with the Generic PHY driver:

https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg253839.html

Eventually we did not make progress towards creating a list of modules
that would require a specialized PHY driver, maybe we can start now?
--
Florian