Re: + mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch added to -mm tree

From: Hui Su
Date: Tue Nov 17 2020 - 10:33:35 EST


On Tue, Nov 17, 2020 at 06:12:46PM +1100, Stephen Rothwell wrote:
> Hi Hugh,
>
> On Mon, 16 Nov 2020 22:17:20 -0800 (PST) Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> >
> > On Mon, 16 Nov 2020, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > >
> > > The patch titled
> > > Subject: mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode()
> > > has been added to the -mm tree. Its filename is
> > > mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch
> > >
> > > This patch should soon appear at
> > > https://ozlabs.org/~akpm/mmots/broken-out/mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch
> > > and later at
> > > https://ozlabs.org/~akpm/mmotm/broken-out/mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch
> > >
> > > Before you just go and hit "reply", please:
> > > a) Consider who else should be cc'ed
> > > b) Prefer to cc a suitable mailing list as well
> > > c) Ideally: find the original patch on the mailing list and do a
> > > reply-to-all to that, adding suitable additional cc's
> > >
> > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> > >
> > > The -mm tree is included into linux-next and is updated
> > > there every 3-4 working days
> > >
> > > ------------------------------------------------------
> > > From: Hui Su <sh_def@xxxxxxx>
> > > Subject: mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode()
> >
> > Andrew, Stephen, please revert this untested "cleanup" from your
> > trees a.s.a.p: it's a disaster for anyone using shmem/tmpfs.
>
> Thanks for that. I have also bisected my boot failures to that commit
> and so have reverted it from linux-next today.
>
> --
> Cheers,
> Stephen Rothwell

Sorry for not full testing the change.
Please ignore this change.

Thanks.