Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

From: Matthew Wilcox
Date: Tue Nov 17 2020 - 12:47:33 EST


On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote:
> On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote:
> > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote:
> > > lru_list lru bit 0 can tell whether the list is
> > > avtive lru-list or not.
> > > lru_list lru bit 1 can tell whether the list is
> > > file lru-list or not.
> > >
> > > And fix some define type in shrink_active_list()
> > > and get_scan_count().
> > >
> > > v1->v2:
> > > correct the commit message, and fix the define type.
> >
> > No, still incorrect.
>
> I am a little confused, can you tell in detail?

Have you booted a kernel with this change? Have you run any kind of
tests on it?