Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'

[Daniel Vetter]

On Tue, Nov 17, 2020 at 06:13:40PM +0000, Lee Jones wrote:
> On Tue, 17 Nov 2020, Lee Jones wrote:
> 
> > On Tue, 17 Nov 2020, Daniel Vetter wrote:
> > 
> > > On Mon, Nov 16, 2020 at 05:40:33PM +0000, Lee Jones wrote:
> > > > Fixes the following W=1 kernel build warning(s):
> > > > 
> > > >  drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_dp_send_query_stream_enc_status’:
> > > >  drivers/gpu/drm/drm_dp_mst_topology.c:3263:6: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
> > > > 
> > > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > > > Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> > > > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > > Cc: David Airlie <airlied@xxxxxxxx>
> > > > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > 
> > > Going to apply this, but I noticed that the return value of the
> > > build_query_stream_enc_status() is pointless. Can you pls follow up with
> > > an additional patch to change that to void?
> > 
> > I can.
> 
> Looks like you're getting dropped again!

I get it on list. So not lost.

tbh my personal cc: is such a disastrous mess it's actually easier to ping
me with an interesting subject on dri-devel here ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch