Re: [PATCH 1/2] soc: qcom: aoss: Expose send for generic usecase

[Chris Lew]

On 11/11/2020 10:33 AM, Sibi Sankar wrote:
> Hey Chris,
> Thanks for the patch.
>
> On 2020-11-03 08:49, Chris Lew wrote:
> > Not all upcoming usecases will have an interface to allow the aoss
> > driver to hook onto. Expose the send api and create a get function to
> > enable drivers to send their own messages to aoss.
> >
> > Signed-off-by: Chris Lew <clew@xxxxxxxxxxxxxx>
> > ---
> >  drivers/soc/qcom/qcom_aoss.c       | 28 +++++++++++++++++++++++++++-
> >  include/linux/soc/qcom/qcom_aoss.h | 33 
> > +++++++++++++++++++++++++++++++++
> >  2 files changed, 60 insertions(+), 1 deletion(-)
> >  create mode 100644 include/linux/soc/qcom/qcom_aoss.h
> >
> > diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> > index ed2c687c16b3..8f052db1880a 100644
> > --- a/drivers/soc/qcom/qcom_aoss.c
> > +++ b/drivers/soc/qcom/qcom_aoss.c
> > @@ -8,10 +8,12 @@
> >  #include <linux/io.h>
> >  #include <linux/mailbox_client.h>
> >  #include <linux/module.h>
> > +#include <linux/of_platform.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_domain.h>
> >  #include <linux/thermal.h>
> >  #include <linux/slab.h>
> > +#include <linux/soc/qcom/qcom_aoss.h>
> >
> >  #define QMP_DESC_MAGIC            0x0
> >  #define QMP_DESC_VERSION        0x4
> > @@ -222,12 +224,15 @@ static bool qmp_message_empty(struct qmp *qmp)
> >   *
> >   * Return: 0 on success, negative errno on failure
> >   */
> > -static int qmp_send(struct qmp *qmp, const void *data, size_t len)
> > +int qmp_send(struct qmp *qmp, const void *data, size_t len)
> >  {
> >      long time_left;
> >      size_t tlen;
> >      int ret;
> >
> > +    if (!qmp || !data)
> > +        return -EINVAL;
> > +
> >      if (WARN_ON(len + sizeof(u32) > qmp->size))
> >          return -EINVAL;
> >
> > @@ -261,6 +266,7 @@ static int qmp_send(struct qmp *qmp, const void
> > *data, size_t len)
> >
> >      return ret;
> >  }
> > +EXPORT_SYMBOL_GPL(qmp_send);
> >
> >  static int qmp_qdss_clk_prepare(struct clk_hw *hw)
> >  {
> > @@ -515,6 +521,26 @@ static void qmp_cooling_devices_remove(struct qmp 
> > *qmp)
> >          thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev);
> >  }
> >
> > +/**
> > + * qmp_get() - get a qmp handle from device tree node
> > + * @np: of node of qmp device
> > + *
> > + * Return: handle to qmp device on success, ERR_PTR() on failure
> > + */
> > +struct qmp_device *qmp_get(struct device_node *np)
> > +{
> > +    struct platform_device *pdev;
> > +    struct qmp *qmp;
>
> Can we use this patch series to determine
> the binding the client are expected to use
> to point to the qmp phandle and have it
> parsed here? This would mean that qmp_get
> would take in device as input instead.
> Bjorn suggested that clients use "qcom,qmp"
> during an offline discussion. Let me know
> what you think.

Hey Sibi,

Yea I think that's a better implementation. I'll upload a second 
revision using "qcom,qmp" as the binding.

> > +
> > +    pdev = of_find_device_by_node(np);
> > +    if (!pdev)
> > +        return ERR_PTR(-EINVAL);
> > +
> > +    qmp = platform_get_drvdata(pdev);
> > +    return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
> > +}
> > +EXPORT_SYMBOL_GPL(qmp_get);
> > +
> >  static int qmp_probe(struct platform_device *pdev)
> >  {
> >      struct resource *res;
> > diff --git a/include/linux/soc/qcom/qcom_aoss.h
> > b/include/linux/soc/qcom/qcom_aoss.h
> > new file mode 100644
> > index 000000000000..05fc0ed3a10d
> > --- /dev/null
> > +++ b/include/linux/soc/qcom/qcom_aoss.h
> > @@ -0,0 +1,33 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
> > + */
> > +
> > +#ifndef __QCOM_AOSS_H__
> > +#define __QCOM_AOSS_H__
> > +
> > +#include <linux/err.h>
> > +#include <linux/of.h>
> > +
> > +struct qmp;
> > +
> > +#if IS_ENABLED(CONFIG_QCOM_AOSS_QMP)
> > +
> > +int qmp_send(struct qmp *qmp, const void *data, size_t len);
> > +struct qmp_device *qmp_get(struct device_node *np);
> > +
> > +#else
> > +
> > +int qmp_send(struct qmp *qmp, const void *data, size_t len)
> > +{
> > +    return -ENODEV;
> > +}
> > +
> > +struct qmp *qmp_get(struct device_node *np)
> > +{
> > +    return ERR_PTR(-ENODEV);
> > +}
> > +
> > +#endif
> > +
> > +#endif

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project