Re: [PATCH][next] nfp: tls: Fix unreachable code issue

From: Simon Horman
Date: Tue Nov 17 2020 - 15:06:52 EST


On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote:
> Fix the following unreachable code issue:
>
> drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
> 208 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
> 299 | fallthrough;
> | ^~~~~~~~~~~
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>