Re: [PATCH v11 09/16] PCI/ERR: Avoid negated conditional for clarity

[Kuppuswamy, Sathyanarayanan]

On 11/17/20 11:19 AM, Sean V Kelley wrote:
> Reverse the sense of the Root Port/Downstream Port conditional for clarity.
> No functional change intended.
>
> [bhelgaas: split to separate patch]
> Link: https://lore.kernel.org/r/20201002184735.1229220-6-seanvk.dev@xxxxxxxxxxxxxxxx
> Signed-off-by: Sean V Kelley <sean.v.kelley@xxxxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> ---
>   drivers/pci/pcie/err.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c
> index 46a5b84f8842..931e75f2549d 100644
> --- a/drivers/pci/pcie/err.c
> +++ b/drivers/pci/pcie/err.c
> @@ -159,11 +159,11 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
>   	 * Error recovery runs on all subordinates of the bridge.  If the
>   	 * bridge detected the error, it is cleared at the end.
>   	 */
> -	if (!(type == PCI_EXP_TYPE_ROOT_PORT ||
> -	      type == PCI_EXP_TYPE_DOWNSTREAM))
> -		bridge = pci_upstream_bridge(dev);
> -	else
> +	if (type == PCI_EXP_TYPE_ROOT_PORT ||
> +	    type == PCI_EXP_TYPE_DOWNSTREAM)
>   		bridge = dev;
> +	else
> +		bridge = pci_upstream_bridge(dev);
>   
>   	bus = bridge->subordinate;
>   	pci_dbg(bridge, "broadcast error_detected message\n");

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer