Re: [PATCH] pwm: core: Use octal permission

From: Lee Jones
Date: Wed Nov 18 2020 - 04:50:03 EST


On Wed, 18 Nov 2020, Joe Perches wrote:

> On Wed, 2020-11-18 at 10:35 +0100, Uwe Kleine-König wrote:
>
> > Actually I'd prefer keeping the symbolic name because this is easier to
> > grep for. So to convince me a better reason than "checkpatch says so" is
> > needed.
>
> https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@xxxxxxxxxxxxxx/
> -------------------------------------------------------------------
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 2 Aug 2016 16:58:29 -0400
>
> The symbolic names are good for the *other* bits (ie sticky bit, and
> the inode mode _type_ numbers etc), but for the permission bits, the
> symbolic names are just insane crap. Nobody sane should ever use them.
> Not in the kernel, not in user space.
>
> Linus

I was waiting for this!

I see your "checkpatch" filter is working well Joe. :)

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog