Re: [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI

[Alexandru Ardelean]

On Tue, Nov 17, 2020 at 1:10 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Nov 17, 2020 at 12:42 PM Jonathan Cameron
> <Jonathan.Cameron@xxxxxxxxxx> wrote:
> >
> > On Tue, 17 Nov 2020 09:52:52 +0200
> > Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:
> >
> > > This change converts the configuration of the dual-channel mode from the
> > > old platform-data, to the device_property_present() function, which
> > > supports both device-tree and ACPI configuration setups.
> > >
> > > With this change the old platform_data include of the driver can be
> > > removed.
> > >
> > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> > Hi Alex,
> >
> > I'm a bit in too minds about device_property_present()
> > vs device_property_read_bool() which are the same thing under the hood.
> >
> > Not sure which one conveys the correct semantics here.
> > I don't feel strongly enough about it though to do more than raise
> > eyebrows (i.e. not blocking this series).
>
> The idea as I understand it is that the 'present' can be run against
> any type of property, while 'bool' is specifically for boolean (the
> similarities is a detail of implementation).

Yeah, I'm also not sure which to use here.
I guess I got used to using device_property_present() a bit more.
They're both pretty used around other drivers.
I guess I'll leave it as is for now, unless other complaints.


>
> --
> With Best Regards,
> Andy Shevchenko