Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly

From: Masami Hiramatsu
Date: Wed Nov 18 2020 - 08:37:15 EST


On Tue, 17 Nov 2020 20:10:10 +0800
Chen Yu <yu.chen.surf@xxxxxxxxx> wrote:

> On Tue, Nov 17, 2020 at 5:53 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >
> > Fix to check the write(2) failure including partial write
> > correctly and try to rollback the partial write, because
> > if there is no BOOTCONFIG_MAGIC string, we can not remove it.
> >
> > Fixes: 85c46b78da58 ("bootconfig: Add bootconfig magic word for indicating bootconfig explicitly")
> > Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> For [1/3] and [2/3]
> Tested-by: Chen Yu <yu.chen.surf@xxxxxxxxx>

Thank you Chen,

BTW, I found another bug in bootconfig error handling.
Steve, did you already pick this series? If not yet, I will update the seires to add that fix.

Thank you,

>
> --
> Thanks,
> Chenyu


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>