Re: [PATCH] pwm: core: Use octal permission

[Soham Biswas]

On Wed, 18 Nov 2020 at 19:29, Soham Biswas <sohambiswas41@xxxxxxxxx> wrote:
>
> Permission bits are easier readable in octal than with using the symbolic names.
>
> Fixes the following warning generated by checkpatch:
>
> drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
>
> +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
>                             &pwm_debugfs_fops);
>
> Signed-off-by: Soham Biswas <sohambiswas41@xxxxxxxxx>
> ---
>  drivers/pwm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 1f16f5365d3c..a8eff4b3ee36 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
>
>  static int __init pwm_debugfs_init(void)
>  {
> -       debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> +       debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL,
>                             &pwm_debugfs_fops);
>
>         return 0;
> --
> 2.29.2
>

I passed -v3 to git-send-email but it didn't work it seems.