Re: [RFC] Add kernel-doc test script

From: Jonathan Corbet
Date: Wed Nov 18 2020 - 11:27:56 EST


On Tue, 17 Nov 2020 17:36:12 -0500
Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote:

> Add a kernel-doc test script to tools/testing/kernel-doc.
>
> radix_tree_lookup_slot test case provided by Matthew Wilcox.
>
> Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> ---
> tools/testing/kernel-doc/test-case.h | 111 ++++++++++
> .../testing/kernel-doc/test-case.man.expected | 150 ++++++++++++++
> .../kernel-doc/test-case.none.expected | 0
> .../kernel-doc/test-case.rst2.expected | 195 ++++++++++++++++++
> .../kernel-doc/test-case.rst3.expected | 195 ++++++++++++++++++
> tools/testing/kernel-doc/test.sh | 90 ++++++++
> 6 files changed, 741 insertions(+)
> create mode 100644 tools/testing/kernel-doc/test-case.h
> create mode 100644 tools/testing/kernel-doc/test-case.man.expected
> create mode 100644 tools/testing/kernel-doc/test-case.none.expected
> create mode 100644 tools/testing/kernel-doc/test-case.rst2.expected
> create mode 100644 tools/testing/kernel-doc/test-case.rst3.expected
> create mode 100755 tools/testing/kernel-doc/test.sh

Seems like a good thing to have overall.

I do worry a bit that the test will be sensitive to *any* change to
kernel-doc output, including formatting changes that might be deliberate.
But if that turns out to be a problem in the real world, we can deal with
it then.

Thanks,

jon