Re: [PATCH v3] pwm: core: Use octal permission
From: Soham Biswas
Date: Wed Nov 18 2020 - 13:39:42 EST
On Wed, 18 Nov 2020 at 23:29, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
>
> On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote:
> > Permission bits are easier readable in octal than with using the
> > symbolic names.
> >
> > Fixes the following warning generated by checkpatch:
> >
> > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are
> > not preferred. Consider using octal permissions '0444'.
> >
> > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL,
> > &pwm_debugfs_fops);
> >
> > Signed-off-by: Soham Biswas <sohambiswas41@xxxxxxxxx>
> > ---
> > drivers/pwm/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks. Though I did unwrap the checkpatch warning message as
> Uwe suggested.
>
> Thierry
Thank You!