Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds

From: Krzysztof Kozlowski
Date: Wed Nov 18 2020 - 15:12:14 EST


On Wed, 18 Nov 2020 at 16:38, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote:
> > COMMON_CLK is a user-selectable option with its own dependencies. The
> > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers
> > should not select COMMON_CLK because they will create a dependency cycle
> > and build failures. For example on MIPS a configuration with COMMON_CLK
> > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by
> > SOC_RT305X) is possible:
> >
> > WARNING: unmet direct dependencies detected for COMMON_CLK
> > Depends on [n]: !HAVE_LEGACY_CLK [=y]
> > Selected by [y]:
> > - SND_SUN8I_CODEC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
> > (ARCH_SUNXI || COMPILE_TEST [=y]) && OF [=y] && (MACH_SUN8I || ARM64 && ARCH_SUNXI || COMPILE_TEST [=y])
> >
> > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_rate':
> > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/ralink/clk.o:(.text+0x88): first defined here
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>
>
> Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
>
> however, I'm not sure the prefix is the one Mark would expect?

Good point, I'll fix it in v3.

Best regards,
Krzysztof