Re: [PATCH 2/3] of: property: add debug info for supplier devices still unavailable

From: Saravana Kannan
Date: Thu Nov 19 2020 - 12:49:27 EST


On Thu, Nov 19, 2020 at 3:18 AM Dong Aisheng <aisheng.dong@xxxxxxx> wrote:
>
> It's normal that supplier devices may still unavaiable when parse DT to
> create dependency. e.g. supplier devices populated by drivers.
> Add debug info for this case.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Saravana Kannan <saravanak@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> ---
> drivers/of/property.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 408a7b5f06a9..21a854e85234 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1150,6 +1150,8 @@ static int of_link_to_phandle(struct device *dev, struct device_node *sup_np,
> * Can't check for cycles or no cycles. So let's try
> * again later.
> */
> + dev_dbg(dev, "Not linking to %pOFP - device may still unavailable\n",
> + sup_np);
> ret = -EAGAIN;
> }
>

All of this is going away[1].
So, Nack.

-Saravana
[1] - https://lore.kernel.org/lkml/20201104232356.4038506-1-saravanak@xxxxxxxxxx/