Re: [PATCH v2] eventfd: convert to ->write_iter()
From: Christoph Hellwig
Date: Thu Nov 19 2020 - 13:03:20 EST
On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote:
> While eventfd ->read() callback was replaced by ->read_iter() recently by
> commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write()
> was not replaced.
>
> Convert also ->write() to ->write_iter() to make the interface more
> consistent and allow non-blocking writes from e.g. io_uring. Also
> reorganize the code and return value handling in a similar way as it was
> done in eventfd_read().
But this patch does not allow non-blocking writes. I'm really
suspicious as you're obviously trying to hide something from us.