Re: [PATCH v3 15/23] mtd: rawnand: diskonchip: Marking unused variables as __always_unused

[Miquel Raynal]

On Mon, 2020-11-09 at 18:21:58 UTC, Lee Jones wrote:
> 'dummy' is never checked (as per the nomenclature) and the use of
> 'emtpymatch' is currently #if 0'ed out.  We could also #if 0 the
> declaration, but #ifery is pretty ugly, so I like to keep it to a
> minimum.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/mtd/nand/raw/diskonchip.c: In function ‘DoC_Delay’:
>  drivers/mtd/nand/raw/diskonchip.c:219:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
>  drivers/mtd/nand/raw/diskonchip.c: In function ‘doc200x_calculate_ecc’:
>  drivers/mtd/nand/raw/diskonchip.c:706:6: warning: variable ‘emptymatch’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> Cc: Dan Brown <dan_brown@xxxxxxxx>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel