Re: [PATCH v7 02/13] misc: bcm-vk: add Broadcom VK driver

[Scott Branden]

Hi Pavel,

On 2020-11-19 2:42 p.m., Pavel Machek wrote:
> Hi!
>
>> Add initial version of Broadcom VK driver to enumerate PCI device IDs
>> of Valkyrie and Viper device IDs.
>>
>> VK based cards provide real-time high performance, high throughput,
>> low latency offload compute engine operations.
>> They are used for multiple parallel offload tasks as:
>> audio, video and image processing and crypto operations.
>>
>> Further commits add additional features to driver beyond probe/remove.
>>
>> Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
>> +++ b/drivers/misc/bcm-vk/Kconfig
>> @@ -0,0 +1,15 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# Broadcom VK device
>> +#
>> +config BCM_VK
>> +	tristate "Support for Broadcom VK Accelerators"
>> +	depends on PCI_MSI
>> +	help
>> +	  Select this option to enable support for Broadcom
>> +	  VK Accelerators.  VK is used for performing
>> +	  specific offload processing.
>> +	  This driver enables userspace programs to access these
>> +	  accelerators via /dev/bcm-vk.N devices.
>> +
>> +	  If unsure, say N.
> Could we
>
> a) align the text the usual way
Please explain what "the usual way" is?
>
> b) explain what the VK is here? What kind of offloads does it do? What
> does "VK" mean?
Sure I can add some more details to the menu.
Offloads such as many parallel crypto, video, compression, and transcode operations are some such offloads.
VK has no real meaning, it is just short for Valkyrie, the first device in the "VK" family.
>
> c) explain where such accelerators might be found.
Such accelerators won't be found in any consumer devices but in high compute data center type locations.
>
> (Is remoteproc framework unusable for this?)
remoteproc has been discussed previously [1] and doesn't suite this application.

[1] https://lore.kernel.org/lkml/CAOesGMg6f2pK4ZZ8bz=0nMgCJG-8JhLZe41prZoGsBhgGs6_jA@xxxxxxxxxxxxxx/

>
> Thanks,
> 									Pavel

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature