Re: [PATCH -tip 31/32] sched: Add a coresched command line option

[Randy Dunlap]

Hi Joel,

On 11/17/20 3:20 PM, Joel Fernandes (Google) wrote:
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index b185c6ed4aba..9cd2cf7c18d4 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -698,6 +698,20 @@
>  			/proc/<pid>/coredump_filter.
>  			See also Documentation/filesystems/proc.rst.
>  
> +	coresched=	[SCHED_CORE] This feature allows the Linux scheduler

Unless I missed it somewhere else, this "SCHED_CORE" string should be
added to Documentation/admin-guide/kernel-parameters.rst, where there is
a list of "qualifiers" for kernel parameters.

(It looks like you are using it as the name of a Kconfig option, which
makes some sense, but that's not how it's [currently] done. :)


> +			to force hyperthread siblings of a CPU to only execute tasks
> +			concurrently on all hyperthreads that are running within the
> +			same core scheduling group.
> +			Possible values are:
> +			'on' - Enable scheduler capability to core schedule.
> +			By default, no tasks will be core scheduled, but the coresched
> +			interface can be used to form groups of tasks that are forced
> +			to share a core.
> +			'off' - Disable scheduler capability to core schedule.
> +			'secure' - Like 'on' but only enable on systems affected by
> +			MDS or L1TF vulnerabilities. 'off' otherwise.
> +			Default: 'secure'.
> +
>  	coresight_cpu_debug.enable
>  			[ARM,ARM64]
>  			Format: <bool>

thanks.
-- 
~Randy