Re: [PATCH net-next V6] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

[Jakub Kicinski]

On Thu, 19 Nov 2020 20:31:41 +0100 Dmytro Shytyi wrote:
>  > Thanks for adding the helper! Looks like it needs a touch up:   
>  
> Understood. Thank you for pointing this out. I think I did not catch this warning as my Makefile didn't include "-Wmissing-prototypes"
> 
>  > net/ipv6/addrconf.c:2579:22: warning: no previous prototype for ‘ipv6_cmp_rcvd_prsnt_prfxs’ [-Wmissing-prototypes] 
>  >  2579 | struct inet6_ifaddr *ipv6_cmp_rcvd_prsnt_prfxs(struct inet6_ifaddr *ifp, 
>  >  |                      ^~~~~~~~~~~~~~~~~~~~~~~~~ 
>  > net/ipv6/addrconf.c:2579:21: warning: symbol 'ipv6_cmp_rcvd_prsnt_prfxs' was not declared. Should it be static? 
>  >   
> 
> Hideaki Yoshifuji helped to improve this patch with suggestions. @Hideaki, should I add "Reported-by" tag in this case?
> Jakub Kicinski also helped to find errors and help with improvement. @Jakub, should I add "Reported-by" tag in this case? 

No need for a tag for me, it would be great if Hideaki was
willing to provide his acked-by or reviewed-by though :)