Re: [PATCH] m68k/mac: Refactor iop_preinit() and iop_init()

From: Geert Uytterhoeven
Date: Fri Nov 20 2020 - 02:57:14 EST


On Fri, Nov 20, 2020 at 5:51 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> The idea behind iop_preinit() was to put the SCC IOP into bypass mode.
> However, that remains unimplemented and implementing it would be
> difficult. Let the comments and code reflect this. Even if iop_preinit()
> worked as described in the comments, it gets called immediately before
> iop_init() so it might as well part of iop_init().
>
> Cc: Joshua Thompson <funaho@xxxxxxxxx>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k for-v5.11 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds