Re: [PATCH] mm,hugetlb: Remove unneded initialization
From: David Hildenbrand
Date: Fri Nov 20 2020 - 04:29:28 EST
On 19.11.20 12:21, Oscar Salvador wrote:
hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0,
but since hstates[] is a global variable, all its fields are defined to
0 already.
Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
---
mm/hugetlb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 37f15c3c24dc..1c69e9044887 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order)
h = &hstates[hugetlb_max_hstate++];
h->order = order;
h->mask = ~((1ULL << (order + PAGE_SHIFT)) - 1);
- h->nr_huge_pages = 0;
- h->free_huge_pages = 0;
for (i = 0; i < MAX_NUMNODES; ++i)
INIT_LIST_HEAD(&h->hugepage_freelists[i]);
INIT_LIST_HEAD(&h->hugepage_activelist);
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
--
Thanks,
David / dhildenb