Re: [PATCH v3] USB: serial: mos7720: defer state restore to a workqueue

From: Johan Hovold
Date: Fri Nov 20 2020 - 04:37:49 EST


On Thu, Nov 19, 2020 at 08:53:00PM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
> simplified if it's done in regular process context and
> this is not a system performance critical path. As such,
> instead of doing the state restore writes in irq context,
> use a workqueue and just do regular synchronous writes.
>
> In addition to the cleanup, this also imposes less on the
> overall system as tasklets have been deprecated because
> of it's softirq implications, potentially blocking a higher
> priority task from running.
>
> Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx>

Now applied, thanks!

Johan