Re: [PATCH v4 4/5] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY

From: Marek Szyprowski
Date: Fri Nov 20 2020 - 04:59:21 EST


Hi Vinod,

On 20.11.2020 10:41, Vinod Koul wrote:
> On 13-11-20, 18:01, Marek Szyprowski wrote:
>> From: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>>
>> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
>> dts: exynos: Remove Exynos5440"). Rework this driver to support PCIe PHY
>> variant found in the Exynos5433 SoCs.
> I am expecting this series to go thru PCI tree, so:
>
> Acked-By: Vinod Koul <vkoul@xxxxxxxxxx>

Frankly, the PHY driver can also go via PHY tree without causing any
issue. The old driver is not used at all, so there is no runtime
dependency. This will help avoiding the merge conflict: yesterday I've
noticed that this patch conflicts with the commit 2f0c9fac3be6 ("phy:
samsung: convert to devm_platform_ioremap_resource") in phy-next. The
resolution is simple (use all the code from the new driver), but if
needed I can resend the PHY driver after a rebase onto the current next
tree.

Best regards

--
Marek Szyprowski, PhD
Samsung R&D Institute Poland