Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm()

From: Linus Torvalds
Date: Fri Nov 20 2020 - 12:31:32 EST


Oh - wait.

Not ack.

Not because this is wrong, but because I think you should remove the
start/end arguments here too.

The _only_ thing they were used for was that "fullmm" flag, afaik. So
now they no longer make sense.

Hmm?

Linus

On Fri, Nov 20, 2020 at 9:22 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Nov 20, 2020 at 6:36 AM Will Deacon <will@xxxxxxxxxx> wrote:
> >
> > Introduce tlb_gather_mmu_fullmm() to make it clearer that this is for the
> > entire mm and WARN() if tlb_gather_mmu() is called with an 'end' address
> > greated than TASK_SIZE.
>
> Ack (but with a spello note - "greated").
>
> Linus