Re: [PATCH v2] arm64: dts: qcom: sc7180: Add prox sensor to LTE sku Lazor boards

From: Stephen Boyd
Date: Fri Nov 20 2020 - 13:21:49 EST


Quoting Doug Anderson (2020-11-20 09:50:38)
> Hi,
>
> On Thu, Nov 19, 2020 at 11:45 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> >
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts
> > @@ -13,6 +13,14 @@ / {
> > compatible = "google,lazor-rev1-sku0", "google,lazor-rev2-sku0", "qcom,sc7180";
> > };
> >
> > +&ap_sar_sensor {
> > + status = "okay";
> > +};
> > +
> > +&ap_sar_sensor_i2c {
> > + status = "okay";
>
> Technically you don't need to mark the i2c bus as "okay" upstream
> because it's already "okay" in "sc7180-trogdor.dtsi". ...or perhaps
> you should add a patch that changes that and makes us match
> downstream. ;-)

Ok I will resend with that extra part too.