Re: [PATCH 001/141] afs: Fix fall-through warnings for Clang
From: Joe Perches
Date: Fri Nov 20 2020 - 18:41:42 EST
On Fri, 2020-11-20 at 17:28 -0600, Gustavo A. R. Silva wrote:
> On 11/20/20 17:18, Joe Perches wrote:
>
> > My preference would be to change these to break and not fallthrough;
>
> And my preference is fallthrough.
If so, that's an unusual choice here as it seems most or all of
the other patches you submitted use break in the same situation
where the next case is a single line break;
see: patches 2, 3, 4, 8, 9, etc...
> Joe, please, let the maintainer share their opinion on this first.
Why?
My preferences are my preferences and I don't mind announcing them.