Re: [PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

[Hemant Kumar]

Hi Mani,
On 11/19/20 10:10 PM, Manivannan Sadhasivam wrote:
> On Mon, Nov 16, 2020 at 02:46:22PM -0800, Hemant Kumar wrote:
> > Loopback test opens the MHI device file node and writes
> > a data buffer to it. MHI UCI kernel space driver copies
> > the data and sends it to MHI uplink (Tx) LOOPBACK channel.
> > MHI device loops back the same data to MHI downlink (Rx)
> > LOOPBACK channel. This data is read by test application
> > and compared against the data sent. Test passes if data
> > buffer matches between Tx and Rx. Test application performs
> > open(), poll(), write(), read() and close() file operations.
> >
> > Signed-off-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>
>
> One nitpick below, with that addressed:
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
[..]
> Effectively this functions does parse and run, so this should be called
> as, "loopback_test_parse_run" or pthread creation should be moved here.
Done.

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project